Avoid duplicate listeners when using useReactiveVar with React.StrictMode #7581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcreighton
force-pushed
the
7509-usereactivevar-strict-mode
branch
from
077ec3d
to
1458973
Compare
benjamn
approved these changes
Jan 14, 2021
src/react/hooks/useReactiveVar.ts
Outdated
Comment on lines
16
to
20
| // equivalent to the following, but shorter.: | ||
| // useEffect(() => { | ||
| // const mute = rv.onNextChange(setValue); | ||
| // return () => mute(); | ||
| // }, [value]) |
There was a problem hiding this comment.
Great idea to make this alternative code even more verbose, to emphasize the shortness of our version. 😂
benjamn
added a commit
that referenced
this pull request
Jan 14, 2021
benjamn
force-pushed
the
7509-usereactivevar-strict-mode
branch
from
1458973
to
f1d088f
Compare
benjamn
force-pushed
the
7509-usereactivevar-strict-mode
branch
from
f1d088f
to
2e13d46
Compare
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7509. Because StrictMode renders functional components twice, duplicate listeners were added to
onNextChange. The trickier part of this is that it doesn't cause inconsistent results until the priority of the update is affected (in the reproduction, returning an unresolved Promise from the button'sonClickhandler resulted in a different priority level in React so the associated duplicate listeners were interleaved with other work resulting in a strange result). We now setonNextChangeonly on the initial mount and when the reactive var's value has changed.Checklist: