Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Partial<TVariables> typing for fetchMore variables, rather than Pick<TVariables, K> #7476

Merged
merged 2 commits into from
Feb 9, 2021
Merged

Use Partial<TVariables> typing for fetchMore variables, rather than Pick<TVariables, K> #7476

merged 2 commits into from
Feb 9, 2021

Conversation

ArnaudBarre
Copy link
Contributor

Updating typing to match current behaviour of merging fetchMore variables with initial variables.

It's actually used in test

I don't know if Pick had a different behaviour in past TS version, but from the documentation, Partial is the util to use in that case

NIT: my IDE also warned me about an outdated JS doc for setVariables

@apollo-cla
Copy link

@ArnaudBarre: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@benjamn benjamn changed the base branch from main to release-3.4 February 9, 2021 21:30
@benjamn benjamn changed the title Use Partial typing for fetchMore variables Use Partial<TVariables> typing for fetchMore variables, rather than Pick<TVariables, K> Feb 9, 2021
Copy link
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea @ArnaudBarre, and sorry for the wait!

@benjamn benjamn added this to the Release 3.4 milestone Feb 9, 2021
@benjamn benjamn merged commit b1800ea into apollographql:release-3.4 Feb 9, 2021
@hwillson hwillson removed this from the MM-2021-06 milestone Jul 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants