fix 'window is not defined'

[yasupeke]

This PR is a fix for the errors that occur during SSR.

[apollo-cla]

@yasupeke: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

[benjamn]

@yasupeke Are you passing connectToDevtools: true explicitly to the ApolloClient constructor?

[yasupeke]

@benjamn Yes, passing. Should I check the typeof window ! == 'undefined' before passing it to the constructor?

[krisgardiner]

Just logged this issue myself, this would indeed fix it! #7453
I was upgrading from v3.2.0 => v3.3.0 and the issue popped up.
Looks like v3.2.0 had this typeof window === 'undefined' check but was removed in v3.3.0.

[Zack0711]

Also logged this issue too. Check the file history and find out it is caused from this commit (83d0b0a) . defaultConnectToDevTools has been set as the default value of connectToDevTools and directly use connectToDevTools to decide if need attach the client instance to window and set up onBroadcast instead of shouldConnectToDevTools which will check the type of window.

I think maybe it can simply add shouldConnectToDevTools back and set it value according to connectToDevTools and the type of window

[benjamn]

Looks good to me. Thanks @yasupeke!