Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Modifying the response data examples (async/await) #7332

Merged
merged 3 commits into from
Nov 18, 2020
Merged

Docs: Modifying the response data examples (async/await) #7332

merged 3 commits into from
Nov 18, 2020

Conversation

alichry
Copy link
Contributor

@alichry alichry commented Nov 16, 2020

I added two examples for response manipulation, one that is synchronous and the other requires async/await. This is crucial since I could not find any documentation on how to manipulate the response in an asynchronous manner, which led me to edit the docs.

See #7328

@apollo-cla
Copy link

@alichry: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

I added 2 examples for response manipulation, one that is synchronous and
the other requires async/await. This is important because I could not find
any documentation on how to manipulate the response in an asynchronous
manner, which led me to editing the docs.

See #7328
@benjamn benjamn self-requested a review November 16, 2020 23:52
@StephenBarlow StephenBarlow merged commit 4003ca0 into apollographql:main Nov 18, 2020
@StephenBarlow
Copy link
Contributor

Thanks @alichry! I've merged and will give it a separate editorial pass shortly.

StephenBarlow pushed a commit that referenced this pull request Nov 18, 2020
benjamn added a commit that referenced this pull request Nov 18, 2020
Co-authored-by: Stephen Barlow <stephenbarlow@apollo-stephenbarlow.gateway.sonic.net>
Co-authored-by: Ben Newman <ben@apollographql.com>
@alichry alichry deleted the patch-1 branch November 19, 2020 17:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants