Make sure to clean context during tearDownQuery
#7276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamn
force-pushed
the
cleanup-contet
branch
from
0ba5abd
to
c079085
Compare
benjamn
approved these changes
Nov 20, 2020
There was a problem hiding this comment.
@dotansimha Although I hope we can prevent torn-down ObservableQuery objects from remaining in memory unnecessarily, I agree this blunt approach seems like a worthwhile extra layer of defense.
benjamn
force-pushed
the
cleanup-contet
branch
from
c079085
to
42fdf44
Compare
|
@benjamn when an observable query is re-observed, it seems to come back to life (I don't know the exact details of this mechanism, but it's happening in my app). In this case however, the context has been deleted, so the query is incorrectly running without the originally specified context. I think this PR should be backed out. The context memory will be freed with the ObservableQuery is garbage collected. |
benjamn
added a commit
that referenced
this pull request
Feb 12, 2021
Thanks to @francisu for pushing back on the reasoning behind #7276: #7276 (comment) Thanks to #7661, we now have a system for programmatically testing garbage collection of discarded objects, so we can actually enforce the expectation that the whole ObservableQuery is garbage collected after the last subscriber is removed (which tears down the ObservableQuery and removes it from the QueryManager).
benjamn
added a commit
that referenced
this pull request
Feb 12, 2021
This was referenced Mar 11, 2021
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @benjamn
This PR should ensure that even if
ObservableInforemains in memory, it won't hold a reference to user-objectcontextafter tear-down.The background is a memory-leak we are chasing in a large-scale app. I think the existence of the
contextreference in Apollo just makes it harder to detect, since it retaining it with no reason.I think even in a use-case of
subscribeover awatchQueryobservable, withoutunsubscribingreproduces that, since Apollo isn't removing theObservableQuerywhile there are subscribers.