Update optimism and fix potential cache.watch memory leak. #7157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwillson
approved these changes
Oct 13, 2020
benjamn
force-pushed
the
update-optimism-and-fix-memory-leak
branch
from
0ed907b
to
fe37d2e
Compare
|
Should this also have been merged back to 2.x? I'm currently working though a memory leak in a vue ap, vue-apollo isn't currently using apollo-client 3.x i'm not sure that this is the fix for my current issue, but merging this back to 2.6.11 would potentially help others! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by @kamilkisiela's comment, but building on the new
optimistic.forgetmethod that I added in benjamn/optimism#84.Should fix #7149 and #7086.