Improvements to options.nextFetchPolicy. #6893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although options.nextFetchPolicy will usually be a string, allowing it to be a function that takes the current FetchPolicy and returns a new (or the same) FetchPolicy allows for more precision, which is important when you're configuring defaultOptions.watchQuery.nextFetchPolicy, since you probably want to alter only some fetch policies and leave the others unmodified.
This was referenced Aug 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we introduced
options.nextFetchPolicyin #6712, it could only be a string, so you needed to have some way of also knowing the currentfetchPolicy, in order to be surenextFetchPolicywas appropriate.Since there has been some interest in setting
defaultOptions.watchQuery.nextFetchPolicyas a global option (e.g. #6712 (comment)), we want to be sure that's possible without making blind guesses about the currentoptions.fetchPolicy. To that end,nextFetchPolicycan now be a function that takes the currentFetchPolicy(which defaults tocache-first) and returns a newFetchPolicybased on the current one (possibly leaving it unchanged). For example, this allows you to transition fromcache-and-networkornetwork-onlytocache-first, but leave other policies the same.The other commits in this PR use
nextFetchPolicyto fix some bugs in our polling implementation, and inObservableQuery#{refetch,setVariables}. With any luck, these changes will help with #6858.