Wire up the @apollo/client/cache entry point
#5577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamn
requested changes
Nov 14, 2019
benjamn
reviewed
Nov 15, 2019
benjamn
reviewed
Nov 15, 2019
benjamn
requested changes
Nov 15, 2019
benjamn
approved these changes
Nov 15, 2019
Similar to the changes made in #5541, this commit adds a direct entry point for the Apollo Client cache code. Importing from `@apollo/client/cache` gives access to the cache code directly, without pulling in other parts of the Apollo Client codebase.
When generating the `dist/core/core.cjs.js` entry point (in `config/prepareDist.js`), we filter and re-export the exports we need from the main Apollo Client CJS bundle (to exclude React related code). This means that consumers of `core.cjs.js` attempt to load the full AC CJS bundle first (before filtering exports), which then means the React require in the AC CJS bundle is attempted and not found (since people using `core.cjs.js` want to use Apollo Client without React). To address this, these changes make React an optional require in the CJS bundle.
This commit switches `react` imports around to be `require`d lazliy. This helps us get away from the AST manipulation used in https://github.com/apollographql/apollo-client/pull/5577/commits/8e22edc3e0a61f6c3507b19c289fbfb60ea437f6a, while still allowing React to be required optionally.
hwillson
force-pushed
the
cache-entry-point
branch
from
573eff8
to
6a5b636
Compare
hwillson
added a commit
that referenced
this pull request
May 29, 2020
PR #5577 introduced a new way of lazily loading React to help prevent modern bundlers from requiring React when used with `@apollo/client/core` (in other words, without any of Apollo Client's React components). While this approach works well for applications that aren't using React, it introduces problems for bundlers and applications that are using React (as outlined in #6035 and #6352). There are several different ways we can address this, and we might do something more substantial in the future, but for now this commit manipulates Apollo Client's core CJS bundle at build time, to make the React require optional. Fixes #6035. Fixes #6352.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the changes made in #5541, this commit adds a direct entry point for the Apollo Client cache code. Importing from
@apollo/client/cachegives access to the cache code directly, without pulling in other parts of the Apollo Client codebase.