Prevent fragments from impacting @client fields #4483
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the `LocalState.resolveSelectionSet` method, we’re adding the `rootValue` to the `resultsToMerge` array multiple times. This is causing issues when a `@client` query, that also includes fragments, is run. If the `@client` field is configured to use a local resolver, when the result is calculated and returned from the local resolver, the fragment results are then merged with the result, along with another copy of the `rootValue`. The second copy of the `rootValue` overrides the value received from the `@client` local resolver. This commit moves the merging of the `rootValue` up a level, so it only happens once, and doesn’t override local resolver results.
hwillson
force-pushed
the
hwillson/resolver-override-fix
branch
from
b5bafd0 to
ec2e7a8
Compare
|
Closing as the fix for #4474 will cover this as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
LocalState.resolveSelectionSetmethod, we’re adding therootValueto theresultsToMergearray multiple times. This is causing issues when a@clientquery, that also includes fragments, is run. If the@clientfield is configured to use a local resolver, when the result is calculated and returned from the local resolver, the fragment results are then merged with the result, along with another copy of therootValue. The second copy of therootValueoverrides the value received from the@clientlocal resolver.This PR moves the merging of the
rootValueup a level, so it only happens once, and doesn’t override local resolver results.