Accepting custom fetch in ApolloBoost

CHANGELOG.md

@@ -10,6 +10,11 @@
   [@JakeDawkins](https://github.com/JakeDawkins) in [#3642](https://github.com/apollographql/apollo-client/pull/3642)  
   [@hwillson](https://github.com/hwillson) in [#3644](https://github.com/apollographql/apollo-client/pull/3644)
 
+### Apollo Boost (vNext)
+
+- Allow `fetch` to be given as a configuration option to `ApolloBoost`.  
+  [@mbaranovski](https://github.com/mbaranovski) in [#3590](https://github.com/apollographql/apollo-client/pull/3590)
+
 ## 2.3.5 (June 19, 2018)
 
 ### Apollo Client (2.3.5)

docs/source/essentials/get-started.md

@@ -162,6 +162,8 @@ Here are the options you can pass to the `ApolloClient` exported from `apollo-bo
   <dd>Is set to `same-origin` by default. This option can be used to indicate whether the user agent should send cookies with requests. See [Request.credentials](https://developer.mozilla.org/en-US/docs/Web/API/Request/credentials) for more details.</dd>
   <dt>`headers`: Object</dt>
   <dd>Header key/value pairs to pass along with the request.</dd>
+  <dt>`fetch`: GlobalFetch['fetch']</dt>
+  <dd>A [`fetch`](https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API) compatible API for making a request.</dd>  
 </dl>
 
 <h2 id="next-steps">Next steps</h2>

packages/apollo-boost/CHANGELOG.md

@@ -1,5 +1,11 @@
 # CHANGELOG
 
+### vNext
+
+- Allow `fetch` to be given as a configuration option to ApolloBoost.  
+  [Issue #3578](https://github.com/apollographql/apollo-client/issues/3578)  
+  [PR #3590](https://github.com/apollographql/apollo-client/pull/3590)
+
 ### 0.1.10
 
 - No changes.

packages/apollo-boost/src/__tests__/config.ts

@@ -1,6 +1,5 @@
 import ApolloClient, { gql, InMemoryCache } from '../';
 import { stripSymbols } from 'apollo-utilities';
-import { HttpLink } from 'apollo-link-http';
 import * as fetchMock from 'fetch-mock';
 
 global.fetch = jest.fn(() =>
@@ -22,6 +21,23 @@ describe('config', () => {
     },
   };
 
+  it('allows you to pass in a custom fetcher', () => {
+    const customFetcher = jest.fn(() =>
+      Promise.resolve({
+        text: () => Promise.resolve('{"data": {"foo": "bar" }}'),
+      }),
+    );
+
+    const client = new ApolloClient({
+      fetch: customFetcher,
+    });
+
+    client.query({ query }).then(({ data }) => {
+      expect(customFetcher).toHaveBeenCalledTimes(1);
+      expect(stripSymbols(data)).toEqual({ foo: 'bar' });
+    });
+  });
+
   it('allows you to pass in a request handler', () => {
     let requestCalled;
 

packages/apollo-boost/src/index.ts

@@ -20,6 +20,7 @@ export interface PresetConfig {
   uri?: string;
   credentials?: string;
   headers?: any;
+  fetch?: GlobalFetch['fetch'];
   fetchOptions?: HttpLink.Options;
   clientState?: ClientStateConfig;
   onError?: ErrorLink.ErrorHandler;
@@ -34,6 +35,7 @@ export default class DefaultClient<TCache> extends ApolloClient<TCache> {
       uri,
       credentials,
       headers,
+      fetch,
       fetchOptions,
       clientState,
       cacheRedirects,
@@ -104,6 +106,7 @@ export default class DefaultClient<TCache> extends ApolloClient<TCache> {
 
     const httpLink = new HttpLink({
       uri: uri || '/graphql',
+      fetch,
       fetchOptions: fetchOptions || {},
       credentials: credentials || 'same-origin',
       headers: headers || {},

packages/apollo-utilities/src/storeUtils.ts

@@ -129,8 +129,8 @@ export function valueToObjectRepresentation(
   } else {
     throw new Error(
       `The inline argument "${name.value}" of kind "${(value as any).kind}"` +
-      'is not supported. Use variables instead of inline arguments to ' +
-      'overcome this limitation.'
+        'is not supported. Use variables instead of inline arguments to ' +
+        'overcome this limitation.',
     );
   }
 }