Tolerate undefined concast.sources if complete called earlier than concast.start
#10526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Fixes issue #10262, since `this.sources.shift()` throws when `complete` is called called before the `Promise` that should have initialized `this.sources` resolves, which can happen when the directive combination `@client @export(as: ...)` is used, because `@export` usage causes a `Promise<Observable[]>` to be passed to the `Concast` constructor instead of the `Observable[]` itself. Although passing a `Promise` to the `Concast` constructor should work, we only exercise that code path in one place, and the additional wrinkle of calling `complete` before the `Promise` resolves was never tested: https://github.com/apollographql/apollo-client/blob/015a1ffff3febe4604956f4bb137a3111f3d8257/src/core/QueryManager.ts#L1226-L1241
benjamn
force-pushed
the
issue-10262-Concast-sources-bug
branch
from
4cf99ba to
4c3db8f
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #10262, since
this.sources.shift()throws whencompleteis called called before thePromisethat should have initializedthis.sourcesresolves, which can happen when the directive combination@client @export(as: ...)is used, because@exportusage causes aPromise<Observable[]>to be passed to theConcastconstructor instead of passing theObservable[]itself.Although passing a
Promiseto theConcastconstructor should work, we only exercise that code path in one place, and the additional wrinkle of callingcompletebefore thePromiseresolves was never tested.