-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate away from @testing-library/react-hooks
#10415
Migrate away from @testing-library/react-hooks
#10415
Conversation
… tests in React 18
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you SO SO much for doing this. Super great not to have to remember which renderHook
we are using 😄.
Feel free to address/ignore the [nit]
comments. There were a couple tests in here that might result in test flake, or false positives with the use of waitFor
. I'm happy to approve once we determine if there is an issue there or not.
Thanks for the review, @jerelmiller! This is ready for a final pass—mostly minor fixes, with one call-out for the changes in 6d1a204, the least straightforward test refactor in the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 💯 Nice work! Love when we can reduce dependencies. Thanks so much for doing this for us!
Closes #10333. Many thanks to @eps1lon for the foundation of this PR originating in eps1lon#1 🙏
To Do
hooks/__tests__/useQuery.test.tsx
which rely on deprecatedresult.all
APIhooks/__tests__/useLazyQuery.test.tsx
hooks/__tests__/useQuery.test.tsx
Checklist: