Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass TCache generic to MutationHookOptions #10223

Merged
merged 7 commits into from
Nov 18, 2022
Merged

Pass TCache generic to MutationHookOptions #10223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
53d3f8b
Pass TCache generic to MutationHookOptions
igrlk Oct 22, 2022
34b1850
Merge branch 'main' into use-mutation-options-missing-tcache-generic
igrlk Oct 25, 2022
77c8d24
Merge branch 'main' into use-mutation-options-missing-tcache-generic
igrlk Oct 31, 2022
d286fa1
Merge branch 'main' into use-mutation-options-missing-tcache-generic
igrlk Nov 4, 2022
de0ba2e
Merge branch 'main' into use-mutation-options-missing-tcache-generic
igrlk Nov 13, 2022
297aae1
Merge branch 'main' into use-mutation-options-missing-tcache-generic
igrlk Nov 18, 2022
cf47496
Add CHANGELOG entry for #10223
jerelmiller Nov 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
[@bignimbus](https://github.com/bignimbus) in [#10282](https://github.com/apollographql/apollo-client/pull/10282)
- Only show dev tools suggestion in the console when `connectToDevTools` is `true`. <br/>
[@chris110408](https://github.com/chris110408) in [#10258](https://github.com/apollographql/apollo-client/pull/10258)
- Pass `TCache` generic to `MutationHookOptions` for better type support in `useMutation`. <br />
[@igrlk](https://github.com/igrlk) in [#10223](https://github.com/apollographql/apollo-client/pull/10223)
- docs: displays the error correctly<br/>
[@ctesniere](https://github.com/ctesniere) in [#10275](https://github.com/apollographql/apollo-client/pull/10275)

Expand Down
2 changes: 1 addition & 1 deletion src/react/hooks/useMutation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export function useMutation<
TCache extends ApolloCache<any> = ApolloCache<any>,
>(
mutation: DocumentNode | TypedDocumentNode<TData, TVariables>,
options?: MutationHookOptions<TData, TVariables, TContext>,
options?: MutationHookOptions<TData, TVariables, TContext, TCache>,
): MutationTuple<TData, TVariables, TContext, TCache> {
const client = useApolloClient(options?.client);
verifyDocumentType(mutation, DocumentType.Mutation);
Expand Down