Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid peer dependencies with 2.3.7 #3737

Closed
1 task done
mikl opened this issue Jul 25, 2018 · 4 comments
Closed
1 task done

Invalid peer dependencies with 2.3.7 #3737

mikl opened this issue Jul 25, 2018 · 4 comments
Assignees

Comments

@mikl
Copy link

mikl commented Jul 25, 2018

After upgrading to apollo-client, and using graphql@0.13, Yarn now will yield the following warning:

apollo-client@2.3.7" has incorrect peer dependency "graphql@^0.11.0 || ^14.0.0"

Since GraphQL 14 is not released yet, this means that users will have to either use a pre-release version or downgrade to graphql v0.11 to avoid getting this error.

Presumably, this error message is mostly cosmetical, and can safely be ignored.

The problem was introduced in commit 46f0fe6, presumably as a solution to #3562.

  • good first issue
@ghost ghost added the good first issue label Jul 25, 2018
@joealden
Copy link

Is this not just as simple as reverting the referenced commit? Should the referenced commit not just be deferred until v14 is out of rc?

@mikl
Copy link
Author

mikl commented Jul 26, 2018

@joealden yes, reverting the commit should fix it, but since I do not understand why @hwillson made it in the first place, I hesitate to make a simple PR reverting his commit.

@hwillson hwillson self-assigned this Jul 27, 2018
hwillson added a commit that referenced this issue Jul 27, 2018
Since the ^ operator only covers any minor version if the major
version is not 0 (since a major version if technically considered
development by semver 2), the current ^0.11.0 || ^14.0.0 graphql
range doesn't cover 0.12.* or 0.13.*.

Fixes #3737.
@hwillson
Copy link
Member

This change was submitted via #3598. The side benefit of that PR was to cleanup the existing graphql peer dep range, which seemed unnecessary. Unfortunately, when I merged that PR I forgot that the ^ operator only covers any minor version IF the major version is not 0 (since a 0 major version is technically considered development by semver 2). Fix coming - thanks!

@divyenduz
Copy link
Contributor

@hwillson When will this be released?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants