Cancel pending notify timeouts when stopping QueryInfo objects (#7935)

apollographql · Apr 5, 2021 · 1d441ce · 1d441ce
1 parent 0b1b8e7
commit 1d441ce
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,6 +10,9 @@
 - Prevent `RenderPromises` memory leak by calling `renderPromises.clear()` after `getMarkupFromTree` finishes. <br/>
   [@benjamn](https://github.com/benjamn) in [#7943](https://github.com/apollographql/apollo-client/pull/7943)
 
+- Cancel pending notify timeout when stopping a `QueryInfo` object. <br/>
+  [@hollandThomas](https://github.com/hollandThomas) in [#7935](https://github.com/apollographql/apollo-client/pull/7935)
+
 ## Apollo Client 3.3.13
 
 ### Improvements

diff --git a/src/core/QueryInfo.ts b/src/core/QueryInfo.ts
@@ -234,6 +234,9 @@ export class QueryInfo {
     if (!this.stopped) {
       this.stopped = true;
 
+      // Cancel the pending notify timeout
+      this.reset();
+
       this.cancel();
       // Revert back to the no-op version of cancel inherited from
       // QueryInfo.prototype.