Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add apollo rust client #4704

Merged
merged 1 commit into from
Jan 18, 2023
Merged

docs: add apollo rust client #4704

merged 1 commit into from
Jan 18, 2023

Conversation

liushv0
Copy link

@liushv0 liushv0 commented Jan 16, 2023

What's the purpose of this PR

add comment of rust adk for apollo

Which issue(s) this PR fixes:

Fixes #None

Brief changelog

docs: add apollo rust client

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

I have read the CLA Document and I hereby sign the CLA

@github-actions
Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@liushv0 liushv0 closed this Jan 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2023
@liushv0 liushv0 reopened this Jan 16, 2023
@nisiyong
Copy link
Member

Nice works! Thanks @liushv0 for contributing to the Rust language client.

And I think maybe we should use gRPC to replace the client protocol HTTP in the future to support multi-language, what do you think? @nobodyiam

@nobodyiam
Copy link
Member

@nisiyong We may add the grpc support in the future but should still keep the HTTP/1.1 protocol for a while to make it backward compatible.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit c7ded89 into apolloconfig:master Jan 18, 2023
@nisiyong
Copy link
Member

@nisiyong We may add the grpc support in the future but should still keep the HTTP/1.1 protocol for a while to make it backward compatible.

It makes sense, we could do it in 2023.

@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants