Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config cookie same site to lax #4664

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

config cookie same site to lax

Brief changelog

  1. set server.servlet.session.cookie.same-site=Lax

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@codecov
Copy link

codecov bot commented Nov 26, 2022

Codecov Report

Merging #4664 (75d18e7) into master (8824b7d) will increase coverage by 0.09%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4664      +/-   ##
============================================
+ Coverage     47.12%   47.22%   +0.09%     
- Complexity     1647     1650       +3     
============================================
  Files           347      347              
  Lines         10643    10643              
  Branches       1057     1057              
============================================
+ Hits           5016     5026      +10     
+ Misses         5323     5314       -9     
+ Partials        304      303       -1     
Impacted Files Coverage Δ
...ervice/service/ReleaseMessageServiceWithCache.java 87.05% <0.00%> (+1.17%) ⬆️
...oServiceRegistryDeregisterApplicationListener.java 75.00% <0.00%> (+45.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@Anilople Anilople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 00d968a into apolloconfig:master Nov 29, 2022
@nobodyiam nobodyiam deleted the cookie-same-site branch November 29, 2022 00:48
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants