-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove app.properties and move some config file's location #4637
refactor: remove app.properties and move some config file's location #4637
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4637 +/- ##
============================================
+ Coverage 47.15% 47.17% +0.02%
- Complexity 1648 1650 +2
============================================
Files 347 347
Lines 10644 10643 -1
Branches 1057 1057
============================================
+ Hits 5019 5021 +2
+ Misses 5320 5319 -1
+ Partials 305 303 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the /apollo/app
won't work after app.properties
is removed, shall we remove the API?
Lines 29 to 32 in b435050
@RequestMapping("app") | |
public String getApp() { | |
return Foundation.app().toString(); | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's the purpose of this PR
try to make config file more simpler.
Which issue(s) this PR fixes:
Fixes #4616 (comment)
Brief changelog
src/main/config/*
tosrc/main/resources/
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.