Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable spring cloud discovery when running test to speed up test pro… #4604

Merged
merged 7 commits into from
Oct 16, 2022

Conversation

wutingjia
Copy link
Contributor

@wutingjia wutingjia commented Oct 14, 2022

What's the purpose of this PR

disable spring cloud discovery when running test to speed up test process and reduce error log

Which issue(s) this PR fixes:

Fixes #4603

Brief changelog

disable spring cloud discovery when running test to speed up test process and reduce error log

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@github-actions
Copy link

github-actions bot commented Oct 14, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #4604 (83fc8f0) into master (25fa47f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4604   +/-   ##
=========================================
  Coverage     46.40%   46.40%           
+ Complexity     1565     1563    -2     
=========================================
  Files           331      331           
  Lines         10360    10360           
  Branches       1043     1043           
=========================================
  Hits           4808     4808           
- Misses         5254     5255    +1     
+ Partials        298      297    -1     
Impacted Files Coverage Δ
...rk/apollo/biz/eureka/ApolloEurekaClientConfig.java 57.14% <0.00%> (-7.15%) ⬇️
...m/ctrip/framework/apollo/biz/config/BizConfig.java 35.71% <0.00%> (-3.58%) ⬇️
...work/apollo/biz/message/DatabaseMessageSender.java 56.25% <0.00%> (+6.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@wutingjia
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@wutingjia
Copy link
Contributor Author

recheck

CHANGES.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Anilople Anilople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 67030ba into apolloconfig:master Oct 16, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: speed up SpringBootTest by close spring cloud discovery
4 participants