Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:add missing @Override annotation for ApolloEurekaClientConfig#getEurekaServerServiceUrls #4575

Merged
merged 1 commit into from
Sep 20, 2022
Merged

fix:add missing @Override annotation for ApolloEurekaClientConfig#getEurekaServerServiceUrls #4575

merged 1 commit into from
Sep 20, 2022

Conversation

CalebZYC
Copy link
Contributor

What's the purpose of this PR

fix:add missing @Override annotation for ApolloEurekaClientConfig#getEurekaServerServiceUrls

Brief changelog

fix:add missing @Override annotation for ApolloEurekaClientConfig#getEurekaServerServiceUrls

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

mghio
mghio approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@mghio mghio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nobodyiam
nobodyiam approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 78aaca1 into apolloconfig:master Sep 20, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2022
@CalebZYC CalebZYC deleted the patch branch October 3, 2022 03:59
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nobodyiam nobodyiam nobodyiam approved these changes

@mghio mghio mghio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@CalebZYC @nobodyiam @mghio