Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deleted at timestamp #4493

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

Fix the deleted at timestamp field is set for records not deleted.

Which issue(s) this PR fixes:

Fixes #4492

Brief changelog

  • add a check before the record is saved to the database

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@nobodyiam nobodyiam requested a review from nisiyong July 30, 2022 12:18
@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2022

Codecov Report

Merging #4493 (f291164) into master (ec658b0) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master    #4493   +/-   ##
=========================================
  Coverage     53.45%   53.45%           
- Complexity     2701     2702    +1     
=========================================
  Files           490      490           
  Lines         15344    15345    +1     
  Branches       1596     1598    +2     
=========================================
+ Hits           8202     8203    +1     
- Misses         6584     6585    +1     
+ Partials        558      557    -1     
Impacted Files Coverage Δ
...rip/framework/apollo/common/entity/BaseEntity.java 0.00% <0.00%> (ø)
...ervice/service/ReleaseMessageServiceWithCache.java 85.88% <0.00%> (+1.17%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mghio
mghio previously approved these changes Jul 31, 2022
Copy link
Contributor

@mghio mghio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

klboke
klboke previously approved these changes Aug 1, 2022
Copy link
Member

@nisiyong nisiyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nisiyong nisiyong merged commit b967dc3 into apolloconfig:master Aug 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2022
@nobodyiam nobodyiam deleted the fix-4492 branch August 8, 2022 14:29
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update item will set DeletedAt timestamp
5 participants