add a config adjust the property source overriden behavior #4409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit e23f628) feat: add a config adjust the property source overriden behavior (cherry picked from commit b6dafd2) feat: add a config adjust the property source overriden behavior (cherry picked from commit 6d4b5d8) feat: add a config adjust the property source overriden behavior (cherry picked from commit 4d1d27d) feat: add a config adjust the property source overriden behavior (cherry picked from commit 6e85efa) feat: add a config adjust the property source overriden behavior for non-spring-boot project fix: change property name refactor: remove isOverrideSystemProperties() refactor: remove isOverrideSystemProperties() test: remove isOverrideSystemProperties() Update apollo-client/src/main/resources/META-INF/additional-spring-configuration-metadata.json Co-authored-by: Jason Song <nobodyiam@gmail.com> fix: rename override system properties, original name is not valid ApolloClientSystemPropertyInitializerTest.testSystemPropertyNames docs: add apollo.override-system-properties docs
Codecov Report
@@ Coverage Diff @@
## master #4409 +/- ##
=========================================
Coverage 53.15% 53.15%
- Complexity 2671 2675 +4
=========================================
Files 489 489
Lines 15277 15291 +14
Branches 1580 1585 +5
=========================================
+ Hits 8120 8128 +8
- Misses 6604 6607 +3
- Partials 553 556 +3
Continue to review full report at Codecov.
|
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
add a config adjust the property source overriden behavior
Which issue(s) this PR fixes:
Fixes #4367 (comment)
Brief changelog
add property
apollo.bootstrap.overrideSystemPropertieschange apollo property source overriden behaviorFollow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.