Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the NPE occurred when using EnableApolloConfig with Spring 3.1.1 #4180

Merged
merged 1 commit into from
Dec 26, 2021

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

Fix the NPE occurred when using EnableApolloConfig with Spring 3.1.1 in master branch

Which issue(s) this PR fixes:

Fixes #4178

Brief changelog

  • Disable namespace placeholder support for Spring version prior to 3.2.x and add necessary warn logs

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@codecov-commenter
Copy link

Codecov Report

Merging #4180 (6a23d8b) into master (7c6c535) will increase coverage by 0.00%.
The diff coverage is 11.11%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4180   +/-   ##
=========================================
  Coverage     52.57%   52.57%           
- Complexity     2616     2620    +4     
=========================================
  Files           484      484           
  Lines         15192    15201    +9     
  Branches       1571     1572    +1     
=========================================
+ Hits           7987     7992    +5     
- Misses         6646     6651    +5     
+ Partials        559      558    -1     
Impacted Files Coverage Δ
...spring/spi/DefaultApolloConfigRegistrarHelper.java 74.19% <11.11%> (-25.81%) ⬇️
...ervice/service/ReleaseMessageServiceWithCache.java 87.05% <0.00%> (+1.17%) ⬆️
.../apollo/internals/RemoteConfigLongPollService.java 78.31% <0.00%> (+1.20%) ⬆️
...nfigservice/filter/ClientAuthenticationFilter.java 93.61% <0.00%> (+2.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c6c535...6a23d8b. Read the comment docs.

@Anilople Anilople merged commit 9a666c8 into apolloconfig:master Dec 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2021
@nobodyiam nobodyiam deleted the fix-4178 branch December 26, 2021 13:27
@nobodyiam nobodyiam added this to the 2.0.0 milestone Jan 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPE occurred when using EnableApolloConfig with Spring 3.1.1
3 participants