refactor: let open api more easier to use and development #3943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobodyiam
reviewed
Sep 3, 2021
apollo-openapi/src/main/java/com/ctrip/framework/apollo/openapi/client/ApolloOpenApiClient.java
Outdated
Show resolved
Hide resolved
...portal/src/main/java/com/ctrip/framework/apollo/openapi/v1/controller/ClusterController.java
Outdated
Show resolved
Hide resolved
…i/client/ApolloOpenApiClient.java Co-authored-by: Jason Song <nobodyiam@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #3943 +/- ##
============================================
- Coverage 51.11% 51.09% -0.03%
- Complexity 2483 2489 +6
============================================
Files 476 481 +5
Lines 14681 14723 +42
Branches 1521 1521
============================================
+ Hits 7504 7522 +18
- Misses 6651 6674 +23
- Partials 526 527 +1
Continue to review full report at Codecov.
|
Use 'T(org.springframework.web.context.request.RequestContextHolder).currentRequestAttributes().getRequest()' instead of '#request'
nobodyiam
requested changes
Sep 14, 2021
Done |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
Let open api more easier to use and development.
Just a simple demo, not the final code.
Which issue(s) this PR fixes:
Fixes #3942
Brief changelog
Add interfaces ApolloXXXOpenApi under java package
com.ctrip.framework.apollo.openapi.api.Let controller under java package
com.ctrip.framework.apollo.openapi.v1.controllerimplement each ApolloXXXOpenApi as server.An interface ApolloOpenApi extends them all, let com.ctrip.framework.apollo.openapi.client.ApolloOpenApiClient implement ApolloOpenApi with compability.
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.