Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spring dependencies from internal code #3937

Merged
merged 25 commits into from
Sep 1, 2021

Conversation

klboke
Copy link
Contributor

@klboke klboke commented Sep 1, 2021

The internal core code cannot couple Spring's dependencies, which results in limited functionality in pure Java API mode

Copy link
Member

@JaredTan95 JaredTan95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #3937 (065f91a) into master (f909b8d) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3937      +/-   ##
============================================
+ Coverage     50.81%   50.84%   +0.02%     
  Complexity     2468     2468              
============================================
  Files           475      475              
  Lines         14608    14608              
  Branches       1523     1523              
============================================
+ Hits           7423     7427       +4     
+ Misses         6655     6651       -4     
  Partials        530      530              
Impacted Files Coverage Δ
...trip/framework/apollo/internals/DefaultConfig.java 78.99% <0.00%> (-0.85%) ⬇️
...mework/apollo/portal/component/PortalSettings.java 65.62% <0.00%> (+7.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f909b8d...065f91a. Read the comment docs.

@JaredTan95 JaredTan95 merged commit ada6294 into apolloconfig:master Sep 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2021
@nobodyiam nobodyiam added this to the 1.10.0 milestone Sep 8, 2021
@nobodyiam nobodyiam modified the milestones: 1.10.0, 1.9.1 Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants