Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add network strategy guideline to docker quick start #3574

Merged
merged 1 commit into from
Feb 27, 2021

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

add network strategy guideline to docker quick start to support external client to connect to apollo-configservice

Which issue(s) this PR fixes:

Fixes #3565

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.

@codecov-io
Copy link

Codecov Report

Merging #3574 (1d5a7cd) into master (aa4c3a9) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3574   +/-   ##
=========================================
  Coverage     50.95%   50.96%           
- Complexity     2324     2325    +1     
=========================================
  Files           447      447           
  Lines         13989    13989           
  Branches       1423     1423           
=========================================
+ Hits           7128     7129    +1     
  Misses         6373     6373           
+ Partials        488      487    -1     
Impacted Files Coverage Δ Complexity Δ
...ervice/service/ReleaseMessageServiceWithCache.java 87.05% <0.00%> (+1.17%) 25.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa4c3a9...1d5a7cd. Read the comment docs.

@nobodyiam nobodyiam merged commit d2059e6 into apolloconfig:master Feb 27, 2021
@nobodyiam nobodyiam deleted the fix-3565 branch February 27, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

按照文档【Docker 方式部署Quick Start】 操作不能部署成功
2 participants