Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hotkeys parameter #62

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Add hotkeys parameter #62

merged 1 commit into from
Jun 19, 2024

Conversation

olivier-lando
Copy link
Member

No description provided.

@olivier-lando olivier-lando merged commit bc2021a into main Jun 19, 2024
4 checks passed
@olivier-lando olivier-lando deleted the hotkeys-parameter branch June 19, 2024 10:08
@joebuys
Copy link

joebuys commented Jun 20, 2024

Oliver-
Will this fix the issue where if I disable a control (say, the seek forward 10 seconds button), it will disable the right-arrow key so users cannot skip forward when the control is disabled?
Thanks!

@olivier-lando
Copy link
Member Author

Hi @joebuys
This new option will disable all shortcuts, not only the one that match buttons that are hidden. Let us know if this suits your needs.

@joebuys
Copy link

joebuys commented Jun 21, 2024

Hello @olivierapivideo ,
This is better than not being able to disable the hotkeys at all. :) At some point, will you be adding the option similar to disabling controls, where you can selectively disable hotkeys? Our situation is that we disable seeking forward for videos that have not yet been completely watched - we need to disable the forward seeking hotkey as well. However, once they have completed watching the video (we store this in our db) we give them the ability to seek, use the progress bar, etc - at which point they should be able to use the hotkeys as well.
THANKS!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants