fix: PD002 checks for zero unconditional RouteRules #440
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alter plugin PD002 to now check for zero unconditional RouteRules.
Without this change PD002 checks for more than one unconditional RouteRule. But it does not check for exactly one. With zero unconditional RouteRules, at runtime the proxy can generate this error:
This change ALSO modifies PD002 to flag the redundant RouteRules when there are multiple. Previously it flagged every unconditional RouteRule (1..n); now it flags only 2..n.