Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PD002 checks for zero unconditional RouteRules #440

Merged
merged 1 commit into from
May 14, 2024

Conversation

DinoChiesa
Copy link
Collaborator

Alter plugin PD002 to now check for zero unconditional RouteRules.

Without this change PD002 checks for more than one unconditional RouteRule. But it does not check for exactly one. With zero unconditional RouteRules, at runtime the proxy can generate this error:

{
  "fault": {
    "faultstring": "Unable to route the message to a Target Endpoint",
    "detail": {
      "errorcode": "messaging.runtime.RouteFailed"
    }
  }
}

This change ALSO modifies PD002 to flag the redundant RouteRules when there are multiple. Previously it flagged every unconditional RouteRule (1..n); now it flags only 2..n.

@ssvaidyanathan ssvaidyanathan merged commit d691151 into apigee:main May 14, 2024
2 checks passed
@DinoChiesa DinoChiesa deleted the rrule-unconditional branch May 14, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants