Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add v2.10 and v2.11 version snapshots #633

Merged
merged 7 commits into from
Feb 3, 2025
Merged

docs: add v2.10 and v2.11 version snapshots #633

merged 7 commits into from
Feb 3, 2025

Conversation

B4nan
Copy link
Member

@B4nan B4nan commented Feb 3, 2025

No description provided.

@B4nan B4nan added the adhoc Ad-hoc unplanned task added during the sprint. label Feb 3, 2025
@github-actions github-actions bot added this to the 107th sprint - Tooling team milestone Feb 3, 2025
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Feb 3, 2025
@B4nan B4nan requested a review from danpoletaev February 3, 2025 13:16
[{"entryPoints":{"index":{"label":"Index","path":"src/index.ts"}},"packageRoot":"/home/jindrichbar/Desktop/apify/apify-client-js","packagePath":".","packageSlug":".","packageName":"apify-client","packageVersion":"2.11.0"}]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh, how come this is an absolute path. the old snapshots have all relative path in here

Copy link
Contributor

@barjin barjin Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, could this be the issue? I've been trying to make it work the whole afternoon, no dice... then I regenerated the snapshots and it started working (for me locally).

The true definition of it worked on my computer.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(btw removing the packageRoot field manually or replacing it with a relative path did not help).

@barjin
Copy link
Contributor

barjin commented Feb 3, 2025

It seems that the newer versions (>4) of @apify/docusaurus-plugin-typedoc-api don't generate valid API snapshots. I have no idea what the difference is - I just generated the snapshots for the 2.10 and 2.11 with older version to unblock this PR.

I'll deal with the docusaurus-plugin-typedoc-api issue separately there.

@B4nan
Copy link
Member Author

B4nan commented Feb 3, 2025

Thanks!

@B4nan B4nan merged commit 61084f4 into master Feb 3, 2025
7 checks passed
@B4nan B4nan deleted the docs-snapshots branch February 3, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants