-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added sync api #69
added sync api #69
Conversation
@LinusU Thanks for the PR. We are going to look into it. 🎈 |
Thank you :) I added usage information to the readme as well |
@pksunkara any news on this? Since this repo has git submodules npm can't install my fork via I would really appreciate this getting merged 👍 |
NanReturnUndefined(); | ||
} | ||
} | ||
optionsResult *res = ParseOptionsObject(Handle<Object>::Cast(args[1])); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename this res
variable as optionsResult
@LinusU Just a few minor variable renaming and this PR should be ready to merge. Thanks. |
Done and done 🍻 |
Thanks 😄 |
Perfect @pksunkara, if you could release this as |
Bump for releasing this on npm - I was scratching my head why |
@pksunkara @kylef can you please release it? |
Fixes #67
This adds
parseSync
that parses on the main thread and returns the result.It also fixes a previous existing test where it compared
result === result
instead ofresult === expected
.