Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added sync api #69

Merged
merged 2 commits into from
May 22, 2015
Merged

added sync api #69

merged 2 commits into from
May 22, 2015

Conversation

LinusU
Copy link
Contributor

@LinusU LinusU commented May 18, 2015

Fixes #67

This adds parseSync that parses on the main thread and returns the result.

It also fixes a previous existing test where it compared result === result instead of result === expected.

@pksunkara
Copy link
Contributor

@LinusU Thanks for the PR. We are going to look into it. 🎈

@LinusU
Copy link
Contributor Author

LinusU commented May 18, 2015

Thank you :) I added usage information to the readme as well

@LinusU LinusU mentioned this pull request May 18, 2015
Closed
@LinusU
Copy link
Contributor Author

LinusU commented May 21, 2015

@pksunkara any news on this?

Since this repo has git submodules npm can't install my fork via "protagonist": "LinusU/protagonist.git#c1b29e2" which makes deploying a bitch currently...

I would really appreciate this getting merged 👍

pksunkara
pksunkara reviewed May 22, 2015
View reviewed changes
src/parse_async.cc
NanReturnUndefined();
}
}
optionsResult *res = ParseOptionsObject(Handle<Object>::Cast(args[1]));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename this res variable as optionsResult

@pksunkara
Copy link
Contributor

@LinusU Just a few minor variable renaming and this PR should be ready to merge. Thanks.

@LinusU
Copy link
Contributor Author

LinusU commented May 22, 2015

Done and done 🍻

pksunkara added a commit that referenced this pull request May 22, 2015
@pksunkara
Merge pull request #69 from LinusU/sync-api
84957c8 
added sync api
@pksunkara pksunkara merged commit 84957c8 into apiaryio:master May 22, 2015
@pksunkara
Copy link
Contributor

Thanks 😄

@LinusU
Copy link
Contributor Author

LinusU commented May 22, 2015

Perfect @pksunkara, if you could release this as 0.19.7 on npm I would be very happy :)

@LinusU LinusU deleted the sync-api branch May 22, 2015 13:24
@JackuB
Copy link

JackuB commented May 24, 2015

Bump for releasing this on npm - I was scratching my head why parseSync isn't working for me. (It should be 0.20.0 though)

@zdne
Copy link
Contributor

zdne commented May 25, 2015

@pksunkara @kylef can you please release it?

This was referenced May 26, 2015
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parseSync
4 participants
@LinusU @pksunkara @JackuB @zdne