This repository has been archived by the owner on Nov 8, 2024. It is now read-only.
Fix "fixed" type attribute not inheriting for empty objects #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylef
commented
May 13, 2019
| @@ -38,7 +38,7 @@ bool refract::inheritsFixed(const IElement& e) | |||
|
|
|||
| bool refract::inheritsFixed(const ObjectElement& e) | |||
| { | |||
| return definesValue(e); | |||
There was a problem hiding this comment.
@tjanc is there any reason why this logic requires values in an object to inherit fixed? I cannot find any cases this change would break, there are no unit/integration tests which cover the case of empty objects and inheriting fixed type attribute.
tjanc
approved these changes
May 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, the logic for inheriting "fixed" requires an object to have a value. An empty object should inherit fixed too.