Skip to content
This repository has been archived by the owner on Jul 9, 2024. It is now read-only.

Update missing value alert #501

Merged
merged 4 commits into from
Dec 26, 2023
Merged

Conversation

vponline
Copy link
Contributor

@vponline vponline commented Dec 8, 2023

@vponline vponline changed the base branch from main to airseeker-telemetry December 8, 2023 14:39
@bdrhn9
Copy link
Contributor

bdrhn9 commented Dec 8, 2023

There are lots of place still Nodary naming populated here some examples:

Also in my opinion variables named as *nodary* that refers reference data should be changed. I don't think variable name changed is urgent but the alerts are.

@vponline
Copy link
Contributor Author

vponline commented Dec 9, 2023

I see thanks, I will go through the rest of the alerts as well then 😄

Copy link
Contributor

@aquarat aquarat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine 😆 but related to Bedirhan's comment it's probably safe to do a project-wide replace of nodary with maybe "source" 🤷 ?

@vponline
Copy link
Contributor Author

Looks fine 😆 but related to Bedirhan's comment it's probably safe to do a project-wide replace of nodary with maybe "source" 🤷 ?

We could almost do this, there are a few db column names still containing nodary, but that should be ok.

@aquarat
Copy link
Contributor

aquarat commented Dec 20, 2023

I'll try and deploy this and see what happens, can always revert.

(update) Deployed... now we wait ~a day.

@aquarat
Copy link
Contributor

aquarat commented Dec 26, 2023

No errors and/or issues, so this is running nicely.

@aquarat aquarat merged commit 0094578 into airseeker-telemetry Dec 26, 2023
@aquarat aquarat deleted the update-missing-value-alert branch December 26, 2023 09:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Airseeker Telemetry]: Swap out/remove error message Nodary reference
3 participants