Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency solhint to v5 #1999

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 17, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
solhint (source) ^4.5.4 -> ^5.0.2 age adoption passing confidence

Release Notes

protofire/solhint (solhint)

v5.0.2

Compare Source

Fixed
Added



v5.0.1

Compare Source

BREAKING CHANGES (refer to v5.0.0)

Fixed an issue on the returining values where only was evaluating the first report instead of all of them.



v5.0.0

Compare Source

BREAKING CHANGES
Solhint EXIT codes

Solhint changed how the exit codes are implemented:

Exit with 0 code When execution was ok and there were no errors when evaluating the code according to the rules

Exit with 1 code When execution was ok and there are errors reported

Exit with 1 code When execution was ok and max warnings is lower than the reported warnings

Exit with 255 code When there's an error in the execution (bad config, writing not allowed, wrong parameter, file not found, etc)

Solhint QUIET mode

QUIET mode (-c quiet) option now works with the warnings and may exit with 1 if there are more than defined by user

Thanks to @​juanpcapurro for providing the code




Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot force-pushed the renovate/solhint-5.x branch 2 times, most recently from 17a0981 to 7dc90fc Compare June 28, 2024 15:38
@renovate renovate bot force-pushed the renovate/solhint-5.x branch 2 times, most recently from 2749cbe to 6793b9e Compare July 25, 2024 14:54
Copy link
Contributor

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - v5 is used elsewhere already

@dcroote dcroote merged commit c43d981 into master Aug 7, 2024
26 checks passed
@dcroote dcroote deleted the renovate/solhint-5.x branch August 7, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant