Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devDependencies (non-major) #1453

Merged
merged 3 commits into from
Sep 27, 2022

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 19, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@types/aws-lambda (source) ^8.10.102 -> ^8.10.106 age adoption passing confidence
@types/express (source) ^4.17.13 -> ^4.17.14 age adoption passing confidence
@types/jest (source) ^29.0.0 -> ^29.0.3 age adoption passing confidence
@types/lodash (source) ^4.14.184 -> ^4.14.185 age adoption passing confidence
@types/yargs (source) ^17.0.12 -> ^17.0.13 age adoption passing confidence
@typescript-eslint/eslint-plugin ^5.36.1 -> ^5.38.1 age adoption passing confidence
@typescript-eslint/parser ^5.36.1 -> ^5.38.1 age adoption passing confidence
eslint (source) ^8.23.0 -> ^8.24.0 age adoption passing confidence
eslint-plugin-functional ^4.2.2 -> ^4.4.0 age adoption passing confidence
eslint-plugin-jest ^27.0.1 -> ^27.0.4 age adoption passing confidence
fast-glob ^3.2.11 -> ^3.2.12 age adoption passing confidence
hardhat-deploy ^0.11.13 -> ^0.11.15 age adoption passing confidence
hardhat-gas-reporter ^1.0.8 -> ^1.0.9 age adoption passing confidence
jest (source) ^29.0.2 -> ^29.0.3 age adoption passing confidence
lerna (source) ^5.5.0 -> ^5.5.2 age adoption passing confidence
solidity-coverage ^0.7.21 -> ^0.8.2 age adoption passing confidence
ts-jest (source) ^29.0.0 -> ^29.0.2 age adoption passing confidence
typescript (source) ^4.8.2 -> ^4.8.3 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - "before 2am on monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, click this checkbox. ⚠ Warning: custom changes will be lost.

This PR has been generated by Mend Renovate. View repository job log here.

@andreogle
Copy link
Member

Looks like eslint-plugin-functional is now complaining about mutating arrays. I'm guessing we want to disable this?

@renovate renovate bot force-pushed the renovate/devdependencies-(non-major) branch 10 times, most recently from 7c94d9c to d2d1fcb Compare September 24, 2022 11:53
@andreogle
Copy link
Member

I've tested locally and the following change fixes the build:

// .eslint.fp.js

- 'functional/immutable-data': ['error', { assumeTypes: true }],
+ 'functional/immutable-data': ['error', { assumeTypes: { forArrays: false, forObjects: true } }],

I personally would prefer to rather stick with immutable arrays everywhere but I've got a feeling that not everyone feels the same way

@renovate renovate bot force-pushed the renovate/devdependencies-(non-major) branch from d2d1fcb to 260e0c4 Compare September 26, 2022 19:50
@Siegrift
Copy link
Contributor

I personally would prefer to rather stick with immutable arrays everywhere but I've got a feeling that not everyone feels the same way

Looking at the code violations, fixing them seems like a big effort and the current implementation is convenient. I'd disable the warnings (at least for now).

@Siegrift Siegrift self-assigned this Sep 27, 2022
@Siegrift Siegrift force-pushed the renovate/devdependencies-(non-major) branch from ecb05c5 to 7de131e Compare September 27, 2022 09:35
@Siegrift Siegrift merged commit 50551a8 into master Sep 27, 2022
@Siegrift Siegrift deleted the renovate/devdependencies-(non-major) branch September 27, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants