fix: parameter provider in a long running http worker #6683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmikalkenas
force-pushed
the
fix-parameters
branch
from
b96f41b
to
cbddb17
Compare
rmikalkenas
force-pushed
the
fix-parameters
branch
from
cbddb17
to
33a2a57
Compare
|
Actually, shouldn't we also don't cache parameters at all? |
|
Interesting use case, I wish we wouldn't cache this at all actually but we don't really have a way to. I think that having the value inside the Parameter is a good DX feature but indeed having "living" values inside immutable Metadata is not the best. @dunglas actually the metadata for Parameters should be cached but values should not. Let's merge this for now as a quick fix. |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of using long running http workers (Roadrunner for example), query parameters and in general parameters functionality tends to persist previous request value due to aggressive caching of resource metadata
Fixing by clearing extra data before parsing new one
Targeting 3.4, but the issue reproducible at 4.0 as well