fix: passing class as parameter in XML ApiResource's definition #6659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSadee
force-pushed
the
fix-remove-setting-class-in-xml-extractor
branch
from
88c8659
to
2ff4527
Compare
This was referenced Sep 23, 2024
Merged
Wojdylak
added a commit
to Sylius/Sylius
that referenced
this pull request
Sep 23, 2024
…nfigs (#16992) | Q | A |-----------------|----- | Branch? | 2.0 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no<!-- don't forget to update the UPGRADE-*.md file --> | Related tickets | api-platform/core#6659 | License | MIT <!-- - Bug fixes must be submitted against the 1.13 branch - Features and deprecations must be submitted against the 1.14 branch - Features, removing deprecations and BC breaks must be submitted against the 2.0 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html -->
soyuka
reviewed
Sep 23, 2024
| @@ -61,7 +61,6 @@ protected function extractPath(string $path): void | |||
| foreach ($xml->resource as $resource) { | |||
| $base = $this->buildExtendedBase($resource); | |||
| $this->resources[$this->resolve((string) $resource['class'])][] = array_merge($base, [ | |||
| 'class' => $this->phpize($resource, 'class', 'string'), | |||
There was a problem hiding this comment.
would it be possible to resolve instead in both extractors? A resource without a class is definitely not valid to me.
There was a problem hiding this comment.
I wondered about this, but in ApiResource the class field does not exist at all if it is not specified here, as far as I have seen, and at the same time the relevant class is indicated as the key, so setting the class here is a kind of unnecessary duplication
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Sylius, where we use API Platform, it is important for us to be able to extend entities and because of this we would like to pass the class as a parameter, which is not possible at the moment due to an error:
This happens because in the XmlResourceExtractor, the key
classis set in the ApiResource metadata with a value that does not point to a specific class, but is a parameter key. This is not done in the YamlResourceExtractor, so in order to make the both extractors consistent with each other, I remove the setting of this wrong value. An alternative would be to set the already resolved class via theresolvemetadata, but I don't think this is needed because the corresponding class is set as a key in the resources array.