fix(openapi): api_entrypoint should use "docs_formats" config #5965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've "fixed" some failing Behat test, but I'm not sure that my fix is valid - perhaps I've changed what's being tested? Also, I seem to have tests failing on a deprecation - I'm not sure if this is something I broke or not? [EDIT: I think it's new deprecation in a package updated a few hours ago.] |
|
Maybe fixes #6010? |
|
Superseded by #6012 - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still have a slightly obscure issue where the api_entrypoint is returning a 406 error in some cases (at least when I load the page with curl with "Accept: text/html" headers). Essentially, its using the formats rather than docs_formats config for that url, and my formats list doesn't include text/html as an option.
There's a test for this currently, I think, but it already passes because the test API has text/html in the config file for both formats and doc_formats, which masks that it's picking the wrong option. I'm not sure if there's a way to modify the config on a single Behat test?