fix(validation): normalize constraint violation list #5866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
force-pushed
the
fix/validation-constraint-normalizer
branch
from
7652bc3
to
4964807
Compare
vincentchalamon
force-pushed
the
fix/validation-constraint-normalizer
branch
2 times, most recently
from
83a38c3
to
e0001f9
Compare
vincentchalamon
force-pushed
the
fix/validation-constraint-normalizer
branch
from
e0001f9
to
4fc56cf
Compare
|
Thanks @vincentchalamon ! |
dannyvw
reviewed
Oct 6, 2023
| } | ||
| ], | ||
| "hydra:title": "An error occurred", | ||
| "hydra:description": "title: This value should not be null.", |
There was a problem hiding this comment.
@soyuka I checked the new release but our tests still fail. This line should be test instead of title
There was a problem hiding this comment.
hmm right it's good inside violations though but indeed this isn't correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5845 (comment) good catch thanks @dannyvw !