Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change tests to not rely on order of insertion #5709

Merged
merged 6 commits into from
Aug 3, 2023

Conversation

GregoireHebert
Copy link
Contributor

@GregoireHebert GregoireHebert commented Aug 1, 2023

Q A
Branch? 3.1
Tickets See here and here
License MIT
Doc PR n/a

@GregoireHebert GregoireHebert changed the base branch from main to 3.1 August 1, 2023 14:41
@GregoireHebert GregoireHebert changed the title fix: add conflict on doctrine/orm:2.16.0 to avoid BC Break fix: change tests to not rely on order of insertion Aug 2, 2023
@soyuka soyuka merged commit 30fdef9 into api-platform:3.1 Aug 3, 2023
@soyuka
Copy link
Member

soyuka commented Aug 3, 2023

thanks @GregoireHebert !

Romaixn pushed a commit to Romaixn/core that referenced this pull request Oct 3, 2023
* fix: add conflict on doctrine/orm:2.16.0

See doctrine/orm#10547

* fix: extend above 2.16 as 2.17 is bugged too

* fix(maxdepthEager): relying on node existance instead of the full representation

* fix: correction for more insert order checks

* fix: correction for more insert order checks

* fix: typo
vasilvestre added a commit to vasilvestre/core that referenced this pull request Nov 8, 2023
This was referenced Nov 8, 2023
vasilvestre added a commit to vasilvestre/core that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants