fix: search on nested sub-entity that doesn't use "id" as its ORM id #5623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just noticed #5618 - not much work to merge as far as i see, but both PRs share a goal to be able to use identifiers that are not always "int $id". |
soyuka
reviewed
Jun 11, 2023
mrossard
force-pushed
the
ormIds
branch
2 times, most recently
from
c565126
to
188cef4
Compare
soyuka
reviewed
Jun 15, 2023
| /** | ||
| * @var DummyWithSubEntity $entity | ||
| */ | ||
| $entity = $this->itemProvider->provide($operation, $uriVariables, $context); |
There was a problem hiding this comment.
I still want to check why this is needed.
There was a problem hiding this comment.
I think a simple explanation is that entityClass gives us the link from the ApiResource to the entity, but nothing really tells us how to convert an entity to a resource, so when the framework gets a subentity it doesn't have a way to know which resource it's supposed to convert it to if you don't do it explicitly in a custom provider.
|
Thanks @mrossard ! |
soyuka
added a commit
to soyuka/core
that referenced
this pull request
Aug 11, 2023
… ORM identifier (api-platform#5623)" This reverts commit b8cbdb1.
Romaixn
pushed a commit
to Romaixn/core
that referenced
this pull request
Oct 3, 2023
… ORM identifier (api-platform#5623)" (api-platform#5744) This reverts commit b8cbdb1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix that use case when ids are not composite.
Composite IDs would still need to be addressed with a custom filter, but that's even more of a fringe case...and would require quite of lot of work as far as i can see. I still left todo comments in case someone wants to tackle that.