Fix/composite identifiers 5396 #5589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sarahshr
force-pushed
the
fix/composite-identifiers-5396
branch
from
39efdff
to
0c0b1bc
Compare
dunglas
approved these changes
May 16, 2023
Sarahshr
force-pushed
the
fix/composite-identifiers-5396
branch
4 times, most recently
from
15e5aeb
to
137a414
Compare
Sarahshr
force-pushed
the
fix/composite-identifiers-5396
branch
from
137a414
to
a9c434a
Compare
soyuka
reviewed
May 23, 2023
| @@ -71,7 +73,7 @@ private function getIdentifierTypes(string $resourceClass, array $properties): a | |||
| foreach ($properties as $property) { | |||
| $propertyMetadata = $this->propertyMetadataFactory->create($resourceClass, $property); | |||
| foreach ($propertyMetadata->getBuiltinTypes() as $type) { | |||
| $types[] = Type::BUILTIN_TYPE_OBJECT === ($builtinType = $type->getBuiltinType()) ? $type->getClassName() : $builtinType; | |||
| $types[$property][] = Type::BUILTIN_TYPE_OBJECT === ($builtinType = $type->getBuiltinType()) ? $type->getClassName() : $builtinType; | |||
There was a problem hiding this comment.
I found the issue, this PR makes an assumption that the parameterName is always in sync with properties, which is not the case as shown here https://github.com/api-platform/core/blob/main/tests/Fixtures/TestBundle/Resources/config/api_resources_odm/resources.xml#L14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows composite identifiers with differents types