Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix parameters extractor in openapi with yaml #5487

Merged
merged 1 commit into from
Mar 28, 2023
Merged

fix parameters extractor in openapi with yaml #5487

merged 1 commit into from
Mar 28, 2023

Conversation

jorissae
Copy link
Contributor

Q A
Branch? 3.1
Tickets #5484
License MIT

vincentchalamon
vincentchalamon reviewed Mar 23, 2023
View reviewed changes
Copy link
Contributor

@vincentchalamon vincentchalamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the bugfix!
A non-regression test would be welcome before accepting this PR

@jorissae jorissae force-pushed the fix-yaml-openapi-extractor-parameters branch 2 times, most recently from 56e233d to e3f89ef Compare March 23, 2023 16:55
@jorissae
Copy link
Contributor Author

@vincentchalamon I added the tests and it's well covered I don't know why it's still marked as not covered

soyuka
soyuka requested changes Mar 23, 2023
View reviewed changes
src/Metadata/Extractor/YamlResourceExtractor.php Outdated Show resolved Hide resolved
src/Metadata/Extractor/YamlResourceExtractor.php Outdated Show resolved Hide resolved
@jorissae jorissae force-pushed the fix-yaml-openapi-extractor-parameters branch from a283289 to 66dc30a Compare March 24, 2023 09:33
@jorissae jorissae requested a review from soyuka March 28, 2023 11:14
soyuka
soyuka approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@soyuka soyuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May you please squash your commits and rename by:

fix(openapi): yaml parameters extractor

@jorissae jorissae force-pushed the fix-yaml-openapi-extractor-parameters branch from 66dc30a to d0b617c Compare March 28, 2023 13:54
@soyuka soyuka merged commit f128e3b into api-platform:3.1 Mar 28, 2023
@soyuka
Copy link
Member

soyuka commented Mar 28, 2023

many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentchalamon vincentchalamon vincentchalamon approved these changes

@soyuka soyuka soyuka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorissae @soyuka @vincentchalamon