fix(metadata): check if elasticsearch is set to false by user through ApiResource (#5115) #5177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannes-io
force-pushed
the
elasticsearch-metadata-resource-provider
branch
from
70acc9e
to
356362d
Compare
|
nice, you can even target the 3.0 branch as its a bug fix. side note: we're working on improvements for Elasticsearch on 3.1! |
Awesome! Would be epic to get this PR merged as it boosts performance instantly! |
Will do. |
|
@soyuka moved to 3.0 |
jannes-io
added a commit
to jannes-io/docs
that referenced
this pull request
Nov 10, 2022
Add documentation to the elasticsearch property to reflect behavior added in api-platform/core#5177
|
thanks ! |
|
Epic guys, thanks for the flawless improvements and speed of merge! |
alanpoulain
pushed a commit
to api-platform/docs
that referenced
this pull request
Nov 10, 2022
Add documentation to the elasticsearch property to reflect behavior added in api-platform/core#5177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
elasticsearchis set tofalseby the user forcefully on theApiResourceattribute, then don't bother fetching the index anyway. This just causes needless slowdowns during container build.I would've liked to revert the logic, in other words, only do the
hasIndicescheck ifelasticsearch: true, but that would introduce a BC break, so after this change, projects using a mix of orm & elasticsearch entities can simply mark their orm entities withelasticsearch: falseand their elasticsearch entities withelasticsearch: true, and the index discovery will only be done on those withelasticsearch: true.Not a big deal if your application is small, but once you start getting into triple digits of entities, doing a request for every single entity causes major slowdowns when
APP_ENVis not set toprod(when the operations aren't cached).