fix(doctrine): isAssociationInverseSide before getMappedBy (#6197)

api-platform · Mar 5, 2024 · f891f16 · f891f16
1 parent 56744dc
commit f891f16
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 1 deletion.
diff --git a/src/Doctrine/Orm/Metadata/Resource/DoctrineOrmLinkFactory.php b/src/Doctrine/Orm/Metadata/Resource/DoctrineOrmLinkFactory.php
@@ -66,8 +66,16 @@ public function createLinksFromRelations(Metadata $operation): array
                 continue;
             }
 
+            if (!$doctrineMetadata->isAssociationInverseSide($property)) {
+                continue;
+            }
+
+            if (!($mappedBy = $doctrineMetadata->getAssociationMappedByTargetField($property))) {
+                continue;
+            }
+
             $relationClass = $doctrineMetadata->getAssociationTargetClass($property);
-            if (!($mappedBy = $doctrineMetadata->getAssociationMappedByTargetField($property)) || !$this->resourceClassResolver->isResourceClass($relationClass)) {
+            if (!$this->resourceClassResolver->isResourceClass($relationClass)) {
                 continue;
             }
 

diff --git a/tests/Doctrine/Orm/Metadata/Resource/DoctrineOrmLinkFactoryTest.php b/tests/Doctrine/Orm/Metadata/Resource/DoctrineOrmLinkFactoryTest.php
@@ -51,6 +51,10 @@ public function testCreateLinksFromRelations(): void
         $classMetadataProphecy->getAssociationMappedByTargetField('relatedNonResource')->willReturn('dummies');
         $classMetadataProphecy->getAssociationMappedByTargetField('relatedDummy')->willReturn(null);
         $classMetadataProphecy->getAssociationMappedByTargetField('relatedDummies')->willReturn('dummies');
+        $classMetadataProphecy->isAssociationInverseSide('relatedNonResource')->willReturn(true);
+        $classMetadataProphecy->isAssociationInverseSide('relatedDummy')->willReturn(true);
+        $classMetadataProphecy->isAssociationInverseSide('relatedDummies')->willReturn(true);
+
         $entityManagerProphecy = $this->prophesize(EntityManagerInterface::class);
         $entityManagerProphecy->getClassMetadata($class)->willReturn($classMetadataProphecy->reveal());
         $managerRegistryProphecy = $this->prophesize(ManagerRegistry::class);

diff --git a/tests/Fixtures/TestBundle/Doctrine/Orm/EntityManager.php b/tests/Fixtures/TestBundle/Doctrine/Orm/EntityManager.php
@@ -45,4 +45,9 @@ public function createQuery($dql = ''): Query
 
         return $this->wrapped->createQuery($dql);
     }
+
+    public function isUninitializedObject(mixed $value): bool
+    {
+        return true;
+    }
 }