refactor: reduce complexity

api-platform · May 26, 2024 · 3535a47 · 3535a47
1 parent d9d318b
commit 3535a47
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/src/Hydra/JsonSchema/SchemaFactory.php b/src/Hydra/JsonSchema/SchemaFactory.php
@@ -95,15 +95,21 @@ public function buildSchema(string $className, string $format = 'jsonld', string
         if ($key = $schema->getRootDefinitionKey()) {
             $definitions[$key]['properties'] = self::BASE_ROOT_PROPS + ($definitions[$key]['properties'] ?? []);
             foreach (array_keys(self::BASE_ROOT_PROPS) as $property) {
-                $definitions[$key]['required'] = array_unique([...($definitions[$key]['required'] ?? []), $property]);
+                $definitions[$key]['required'] ??= [];
+                if (!\in_array($property, $definitions[$key]['required'], true)) {
+                    $definitions[$key]['required'][] = $property;
+                }
             }
 
             return $schema;
         }
         if ($key = $schema->getItemsDefinitionKey()) {
             $definitions[$key]['properties'] = self::BASE_PROPS + ($definitions[$key]['properties'] ?? []);
             foreach (array_keys(self::BASE_PROPS) as $property) {
-                $definitions[$key]['required'] = array_unique([...($definitions[$key]['required'] ?? []), $property]);
+                $definitions[$key]['required'] ??= [];
+                if (!\in_array($property, $definitions[$key]['required'], true)) {
+                    $definitions[$key]['required'][] = $property;
+                }
             }
         }