Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Accept.php #40

Merged

Conversation

mgralikowski
Copy link
Contributor

@mgralikowski mgralikowski commented Aug 31, 2023

Fixes:

preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated in /var/www/html/vendor/api-ecosystem-for-laravel/dingo-api/src/Http/Parser/Accept.php on line 70  

Fix #37

Fixes: preg_match(): Passing null to parameter api-ecosystem-for-laravel#2 ($subject) of type string is deprecated
@mgralikowski
Copy link
Contributor Author

mgralikowski commented Aug 31, 2023

Ok, I noticed another PR that resolves this issue too, but minimally in a different way :)
Mine uses more Laravel-way as uses a native functionality of the "header" method.

#39

@mgralikowski
Copy link
Contributor Author

@specialtactics could you review my PR? It's trivial ;)

@specialtactics specialtactics merged commit a5b901d into api-ecosystem-for-laravel:master Feb 11, 2024
@specialtactics
Copy link
Contributor

Thank you @mgralikowski tagged as [v4.1.2]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning on requests with no Accept header set
2 participants