Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Route.php (PHP 8.2 Compatible) #38

Merged
merged 1 commit into from
Feb 11, 2024
Merged

Update Route.php (PHP 8.2 Compatible) #38

merged 1 commit into from
Feb 11, 2024

Conversation

jmarcher
Copy link
Contributor

No description provided.

@filipstefanovski
Copy link

We really need this change, because the package generates warnings on PHP 8.2 Can you check why the check failed?

filipstefanovski
filipstefanovski approved these changes Oct 5, 2023
View reviewed changes
Copy link

@filipstefanovski filipstefanovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine as it adds the missing variable

@specialtactics specialtactics merged commit 24f17dd into api-ecosystem-for-laravel:master Feb 11, 2024
@specialtactics
Copy link
Contributor

Thank you @jmarcher tagged as [v4.1.2]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thanatkron thanatkron thanatkron approved these changes

@specialtactics specialtactics specialtactics approved these changes

@filipstefanovski filipstefanovski filipstefanovski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmarcher @filipstefanovski @specialtactics @thanatkron