fix: fix double call into population card

src/components/CreationCohort/DiagramView/components/PopulationCard/PopulationCard.tsx

@@ -1,4 +1,4 @@
-import React, { useState, useEffect } from 'react'
+import React, { useState, useEffect, useRef } from 'react'
 
 import { Button, IconButton, Chip, CircularProgress, Typography } from '@mui/material'
 
@@ -16,13 +16,13 @@ import { MeState } from 'state/me'
 
 import { ScopeTreeRow } from 'types'
 import { getSelectedScopes, filterScopeTree } from 'utils/scopeTree'
-import servicesPerimeters from 'services/aphp/servicePerimeters'
 
 import useStyles from './styles'
 
 const PopulationCard: React.FC = () => {
   const classes = useStyles()
   const dispatch = useAppDispatch()
+  const isRendered = useRef<boolean>(false)
 
   const {
     request: { selectedPopulation = [], ...requestState },
@@ -56,9 +56,7 @@ const PopulationCard: React.FC = () => {
       subItems: []
     }))
 
-    const allowSearchIpp = await servicesPerimeters.allowSearchIpp(_selectedPopulations)
-
-    dispatch<any>(buildCohortCreation({ selectedPopulation: _selectedPopulations, allowSearchIpp: allowSearchIpp }))
+    dispatch<any>(buildCohortCreation({ selectedPopulation: _selectedPopulations }))
     onChangeOpenDrawer(false)
   }
 
@@ -87,14 +85,17 @@ const PopulationCard: React.FC = () => {
 
   useEffect(() => {
     if (
+      !isRendered.current &&
       !openDrawer &&
-      scopesList &&
-      scopesList.length === 1 &&
-      requestState.requestId &&
-      (selectedPopulation === null || (selectedPopulation && selectedPopulation.length === 0))
+      scopesList?.length === 1 &&
+      requestState?.requestId &&
+      (selectedPopulation === null || selectedPopulation?.length === 0)
     ) {
       const savedSelectedItems: ScopeTreeRow[] = getSelectedScopes(scopesList[0], [], scopesList)
       submitPopulation(savedSelectedItems)
+      isRendered.current = true
+    } else {
+      isRendered.current = false
     }
   }, [scopesList, requestState])
 

src/state/cohortCreation.ts

@@ -254,7 +254,6 @@ type BuildCohortReturn = {
 }
 type BuildCohortParams = {
   selectedPopulation?: ScopeTreeRow[] | null
-  allowSearchIpp?: boolean
 }
 const buildCohortCreation = createAsyncThunk<BuildCohortReturn, BuildCohortParams, { state: RootState }>(
   'cohortCreation/build',
@@ -287,10 +286,9 @@ const buildCohortCreation = createAsyncThunk<BuildCohortReturn, BuildCohortParam
         )
       }
 
-      let allowSearchIpp = false
-      if (_selectedPopulation) {
-        allowSearchIpp = await services.perimeters.allowSearchIpp(_selectedPopulation as ScopeTreeRow[])
-      }
+      const allowSearchIpp = _selectedPopulation
+        ? await services.perimeters.allowSearchIpp(_selectedPopulation as ScopeTreeRow[])
+        : false
 
       let _initTemporalConstraints