Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 4271: #4272

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Issue 4271: #4272

merged 1 commit into from
Feb 27, 2024

Conversation

rosco54
Copy link
Contributor

@rosco54 rosco54 commented Feb 27, 2024

Bug introduced in 3.46.0 caused collapsed series' to be scanned for min and max values only to find null values, setting w.globals.hasNullValues, which causes the effects described in the issue report.

Fixes #4271

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

Bug introduced in 3.46.0 caused collapsed series' to be scanned for
min and max values only to find null values, setting
w.globals.hasNullValues, which causes the effects described in the
issue report.
@rosco54
Copy link
Contributor Author

rosco54 commented Feb 27, 2024

Also, w.globals.hasNullValues appears to only be set to false during startup, and is never reset after being set true. This should probably be looked at.

@junedchhipa junedchhipa merged commit 68c7728 into apexcharts:main Feb 27, 2024
@rosco54 rosco54 deleted the Issue_4271 branch February 29, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 3.46.0 causes Area Chart Gradient to "Glitch" when Hiding / Showing Data Series
2 participants