Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deformatter (apertium-destxt) escape chars #93

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

singh-lokendra
Copy link
Collaborator

sushain97
sushain97 previously approved these changes Mar 9, 2021
sushain97
sushain97 previously approved these changes Mar 9, 2021
@sushain97
Copy link
Member

(i'm fine with us switching to GH actions but it should really be a separate PR, imo)

@singh-lokendra
Copy link
Collaborator Author

I noticed travis builds weren't working so I added the workflow file. I'll make a separate PR for GH acions

@eagad
Copy link

eagad commented Mar 10, 2021

@Vaydheesh can you also include ['*', '#', '+', '~'] in escape_chars list, please?

@singh-lokendra
Copy link
Collaborator Author

@eagad The escape_chars is used to wrap apertium-destxt which is generated from txt-format.xml.
Since I am not from linguistics background, I don't know whether this change has potential to break things or not.
Maybe other developers can clarify on implications of this change

@singh-lokendra
Copy link
Collaborator Author

can you also include ['*', '#', '+', '~'] in escape_chars list, please?

@sushain97 any thoughts on this?

@TinoDidriksen
Copy link
Member

*#+~ are not escaped in the input - see https://github.com/apertium/lttoolbox/blob/master/lttoolbox/fst_processor.cc#L39

They are escaped when expanding: https://github.com/apertium/lttoolbox/blob/master/lttoolbox/expander.cc#L116

But de/re-formatters must not touch *#+~.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

terminate called after throwing an instance of 'Exception' what(): Error: Malformed input stream.
4 participants